Include RSD package path in include option by default #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exclude options with user-supplied ones
necolas
reviewed
Nov 14, 2024
necolas
reviewed
Nov 14, 2024
| return [ | ||
| // Exclude TypeScript declaration files by default | ||
| // because it never contains any CSS rules. | ||
| '**/*.d.ts', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ref. facebook/react-strict-dom#236 (comment)
At the moment, users manually have to add react-strict-dom source files in their config.
This is cumbersome and can be especially error-prone in a monorepo because packages may get hoisted to a root depending on how project is configured.
This PR pre-configures
includeoption by adding the appropriate glob paths by default so that users do not need to add it to their config.How
By using
require.resolve('react-strict-dom/package.json')to determine the installed path of react-strict-dom.Users will still need to provide their application source code paths in their
includeoption, so the defaultincludeandexcludepaths are now always added to the config.Test Plan