Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt #430

Merged
merged 3 commits into from
Feb 11, 2024
Merged

BigInt #430

merged 3 commits into from
Feb 11, 2024

Conversation

danilolmc
Copy link
Contributor

No description provided.

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilolmc, what do you think about consider the idea about translating the word bigint in the article content as número inteiro grande or inteiro grande or inteiro maior?

@Peruibeloko, @jonnathan-ls, @odsantos, what do you think about the suggestion I did?

@nazarepiedady nazarepiedady requested review from odsantos, jonnathan-ls and a team February 6, 2024 20:37
@Peruibeloko
Copy link
Contributor

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translate Promise to Promessa for example :)

@danilolmc
Copy link
Contributor Author

danilolmc commented Feb 6, 2024

I agree with @Peruibeloko, since BigInt is just like Promise and the data type name itself.

@Peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

@Peruibeloko
Copy link
Contributor

@danilolmc Yes, that would be the case. Just a suggestion, of course.

@danilolmc
Copy link
Contributor Author

Ok, no problem, I'm going to capitalize them!

@nazarepiedady
Copy link
Member

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translate Promise to Promessa for example :)

@Peruibeloko, I was talking about to translate the usage of the word bigint where it is not reference the data type.

@Peruibeloko
Copy link
Contributor

@nazarepiedady the problem is that bigint always refers to the data type

Copy link
Contributor

@Peruibeloko Peruibeloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilolmc Solicitei algumas mudanças, deve ser rápido

1-js/99-js-misc/05-bigint/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/05-bigint/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/05-bigint/article.md Show resolved Hide resolved
1-js/99-js-misc/05-bigint/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/05-bigint/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/05-bigint/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/05-bigint/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/05-bigint/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc
Copy link
Contributor Author

/done

@odsantos
Copy link
Contributor

odsantos commented Feb 7, 2024

I agree with @Peruibeloko, since BigInt is just like Promise and the data type name itself.

@Peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

Seems good, as the Portuguese 'mdn' link, and other accepted suggestions here.

@nazarepiedady nazarepiedady merged commit 837287f into javascript-tutorial:master Feb 11, 2024
1 check passed
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants