Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor, operator "new" #400

Merged

Conversation

PedroDousseau
Copy link
Contributor

Hello, just came back from a long time ago. I saw that my name is still linked with this article so i decided to continue with the translation of it.

I don't have access anymore to the other PR I opened (#88), so I'm creating this one, hope it's ok.

Let me know if there's something missing,

@javascript-translate-bot

Error: the article already has PR number in the Progress Issue #1, it's 88 ⁉️

@odsantos
Copy link
Contributor

Hi @PedroDousseau ,

The following files seem missing:

  • 1-js/04-object-basics/06-constructor-new/2-calculator-constructor/_js.view/test.js
  • 1-js/04-object-basics/06-constructor-new/3-accumulator/_js.view/solution.js
  • 1-js/04-object-basics/06-constructor-new/3-accumulator/_js.view/test.js

Are you going to include them?

Thank you,
Osvaldo.

@PedroDousseau
Copy link
Contributor Author

Hi @PedroDousseau ,

The following files seem missing:

* 1-js/04-object-basics/06-constructor-new/2-calculator-constructor/_js.view/test.js

* 1-js/04-object-basics/06-constructor-new/3-accumulator/_js.view/solution.js

* 1-js/04-object-basics/06-constructor-new/3-accumulator/_js.view/test.js

Are you going to include them?

Thank you, Osvaldo.

Oh, I forgot them. I just translated

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ ( Looks Great To Me )

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to be merged to the master. Thanks for your contribution @PedroDousseau.

@nazarepiedady nazarepiedady merged commit 90e5ecb into javascript-tutorial:master Mar 18, 2024
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants