Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class checking: "instanceof" #398

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Class checking: "instanceof" #398

merged 3 commits into from
Jul 16, 2023

Conversation

danilolmc
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team March 14, 2023 18:12
@javascript-translate-bot javascript-translate-bot mentioned this pull request Mar 14, 2023
Open
@odsantos
Update article.md
a20f375 
Remove the original English paragraph.
odsantos
odsantos requested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

Here is a review.

"importance: 5" is not translated (the number here is only an example).

Please, do not forget to replace English hyperlinks with Portuguese ones when those are available and their explanation is good enough for being a replacement.

I appreciate it if you tell me if you disagree with any suggestion.

Thank you,
Osvaldo.

1-js/09-classes/06-instanceof/1-strange-instanceof/solution.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/1-strange-instanceof/solution.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/1-strange-instanceof/task.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/article.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/article.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/article.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/article.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/article.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/article.md Outdated Show resolved Hide resolved
1-js/09-classes/06-instanceof/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team March 16, 2023 02:18
odsantos
odsantos approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

We'll need to wait for a review by another maintainer for merging this translation.

Thank you,
Best wishes.

@odsantos odsantos marked this pull request as draft March 16, 2023 19:34
@odsantos odsantos marked this pull request as ready for review March 16, 2023 19:35
jonnathan-ls
jonnathan-ls approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Mee

@jonnathan-ls jonnathan-ls merged commit 887e731 into javascript-tutorial:master Jul 16, 2023
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

@odsantos odsantos odsantos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danilolmc @javascript-translate-bot @odsantos @jonnathan-ls