Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixins #382

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Mixins #382

merged 2 commits into from
Jul 16, 2023

Conversation

danilolmc
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2023

CLA assistant check
All committers have signed the CLA.

@odsantos
Copy link
Contributor

Hi @DaniloLima122 ,

Appreciated your efforts.
Under the title For New Translators, on the top of #1 , you may find instructions for claiming the article and naming the pull request.

Would you please follow them?
Thanks.

@danilolmc danilolmc changed the title Update mixins article Mixins Mar 11, 2023
@danilolmc
Copy link
Contributor Author

Hi @odsantos !

Thank you for the tips!

Now I think the PR name is correct, according the name of the article!

@odsantos
Copy link
Contributor

Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks.

@danilolmc
Copy link
Contributor Author

Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks.

Hi @odsantos , thank you! It's done!

@odsantos
Copy link
Contributor

Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page.
The bot could reserve it in your name, and usually it can also assign the PR later, but no worries the PR is there as well, done manually.
Thanks for your efforts.

@danilolmc
Copy link
Contributor Author

Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page.
The bot could reserve it in your name, and usually it can also assign the PR later, but no worries the PR is there as well, done manually.
Thanks for your efforts.

Hi @odsantos ! Great, I won't, thanks for your support! 😁

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

Here is a review.

Please keep the translation line numbers matching the original (English) even if there is too little or too much space, and if you do not mind, also translate the text inside strings, but not variable names as you did.

Appreciate it if you tell me where you might disagree with this revision.

Thank you,
Osvaldo.

1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@odsantos
Copy link
Contributor

Hi @danilolmc ,

Here, the bot explains how to indicate that a translation is ready for another review.

Your PR is still marked with "changes requested" under Labels on the top right of this page, which was done by the bot after my review.

Having that label, maintainers might believe that something is still to be done, and not have a look at a PR unless much time has passed.

Since you still might wish to make changes, when you have finished would you tell the bot you're done?

Please, only comment with "/done" here, without quotes or anything else.

Meanwhile, I am afraid I'll wait for that and the subsequent bot request for another review.

Thank you,
Osvaldo.

@danilolmc
Copy link
Contributor Author

/done

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

We need that two maintainers review a translation for merging it.
So, we'll wait for a review by another maintainer.

Thank you,
Best wishes.

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Mee

@danilolmc
Thank you for contribution

@jonnathan-ls jonnathan-ls merged commit 0b207b5 into javascript-tutorial:master Jul 16, 2023
@javascript-translate-bot

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

@jonnathan-ls
Copy link
Contributor

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

Updated

@danilolmc
Copy link
Contributor Author

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

Updated

I had changed my github username, but I had already finished the translation before it was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants