-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototypal inheritance #230
Prototypal inheritance #230
Conversation
- Tasks 'importance'; - Trocar 'setar' por 'configurar'; - Translate strings in code;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @flaviohblima ,
Here is a review.
Please, feel free to leave a note where you might disagree.
Thank you,
Osvaldo.
1-js/08-prototypes/01-prototype-inheritance/1-property-after-delete/task.md
Outdated
Show resolved
Hide resolved
1-js/08-prototypes/01-prototype-inheritance/2-search-algorithm/solution.md
Outdated
Show resolved
Hide resolved
1-js/08-prototypes/01-prototype-inheritance/2-search-algorithm/solution.md
Outdated
Show resolved
Hide resolved
1-js/08-prototypes/01-prototype-inheritance/2-search-algorithm/task.md
Outdated
Show resolved
Hide resolved
1-js/08-prototypes/01-prototype-inheritance/3-proto-and-this/solution.md
Outdated
Show resolved
Hide resolved
Please make the requested changes. After it, add a comment "/done". |
…elete/task.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…/solution.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…/solution.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…/task.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…olution.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…olution.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…ask.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…lution.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…lution.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…lution.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
…sk.md Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
/done |
Hi @flaviohblima , Still working in this one? Please, let me know if you haven't time and I might be able to resolve it. Thanks, |
Hi @odsantos , Sorry I could not resolve this pull request. In any case, feel free to resolve the conflicts and close it. Team work is always quickier! Thank you, |
Hi @flaviohblima , I'll try to resolve the conflicts but keep it open. Thank you, |
@Peruibeloko, @jonnathan-ls, do you have time to see what is possible to do in relation to this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parece bastante coisa, mas na verdade são só alterações pequenas e pedidos de tradução do código.
Acredito que seja importante traduzir os nomes usados nos exemplos do artigo, já que o tópico pode ser de difícil compreensão para iniciantes
|
||
In programming, we often want to take something and extend it. | ||
Na programação, nós sempre queremos extender algum comportamento. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Na programação, nós sempre queremos extender algum comportamento. | |
Na programação, é comum querermos extender algum comportamento. |
1. `true`, obtido de `rabbit`. | ||
2. `null`, obtido de `animal`. | ||
3. `undefined`, essa propriedade não existe mais. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. `true`, obtido de `rabbit`. | |
2. `null`, obtido de `animal`. | |
3. `undefined`, essa propriedade não existe mais. | |
1. `true`, obtido de `coelho`. | |
2. `null`, obtido de `animal`. | |
3. `undefined`, essa propriedade não existe mais. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traduzir as variáveis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traduzir o código
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traduzir o código
|
||
For that reason `admin.fullName` works correctly in the code below: | ||
Por essa razão, `admin.fullName` funciona corretamente no código abaixo: | ||
|
||
```js run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traduzir o código
|
||
The call `rabbit.sleep()` sets `this.isSleeping` on the `rabbit` object: | ||
A chamada de `rabbit.sleep()` configura `this.isSleeping` no objeto `rabbit`: | ||
|
||
```js run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traduzir o resto do código
|
||
For instance: | ||
Por exemplo: | ||
|
||
```js run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traduzir o código
|
||
```smart header="Almost all other key/value-getting methods ignore inherited properties" | ||
Almost all other key/value-getting methods, such as `Object.keys`, `Object.values` and so on ignore inherited properties. | ||
```smart header="Quase todas as outras chaves/métodos *obtém-valor* ignoram propriedades herdadas." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```smart header="Quase todas as outras chaves/métodos *obtém-valor* ignoram propriedades herdadas." | |
```smart header="Quase todos os métodos que obtém valores a partir de chaves ignoram propriedades herdadas." |
- If we call `obj.method()`, and the `method` is taken from the prototype, `this` still references `obj`. So methods always work with the current object even if they are inherited. | ||
- The `for..in` loop iterates over both its own and its inherited properties. All other key/value-getting methods only operate on the object itself. | ||
- No Javascript, todos os objetos possuem uma propriedade `[[Prototype]]` escondida que ou é um objeto ou é `null`. | ||
- Nós podemos usar `obj.__proto__` para acessá-lo (um histórico getter/setter, mas já existem alternativas, que veremos em breve). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Nós podemos usar `obj.__proto__` para acessá-lo (um histórico getter/setter, mas já existem alternativas, que veremos em breve). | |
- Nós podemos usar `obj.__proto__` para acessá-lo (um getter/setter mantido historicamente, mas já existem alternativas, que veremos em breve). |
Please make the requested changes. After it, add a comment "/done". |
@Peruibeloko, I was talking about to edit this pull request and approved if possible. |
@nazarepiedady I believe the repo is write protected, but it I'll see what I can do |
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Prototypal inheritance