Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Jar tasks on Gradle Build #57

Closed
jeandersonbc opened this issue May 22, 2018 · 4 comments
Closed

Add support to Jar tasks on Gradle Build #57

jeandersonbc opened this issue May 22, 2018 · 4 comments

Comments

@jeandersonbc
Copy link
Collaborator

The current Gradle support covers all original compilation tasks and test execution.
Another important task that must be covered, and it is between compile and test is the build task.
The build task is responsible for generating some important jars.

@jeandersonbc
Copy link
Collaborator Author

According to my python script that compares the Ant and Gradle execution, I'm missing two jars:

$ python3 main.py
Running command "ant clean build"
Finished in 18.53 secs
Running command "./gradlew clean buildJars --info"
Finished in 9.52 secs
Total files: 1839
Common files: 1836
Missing files: 3
 - /Users/jeandersonbc/projects/jpf/jpf-core/build/RunJPF.jar
 - /Users/jeandersonbc/projects/jpf/jpf-core/build/RunTest.jar
 - /Users/jeandersonbc/projects/jpf/jpf-core/build/classes/java/nio/package-info.class

I'm working on those two missing jars.
I don't know why the gradle build is not copying the package-info.class file into the build directory, but I believe this is not critical right now.

@gayanW
Copy link
Collaborator

gayanW commented May 30, 2018

package-info.class seems to go in jpf-classes.jar

cyrille-artho pushed a commit that referenced this issue May 31, 2018
* Organized Gradle tasks

* Implemented task to generate 'jpf-classes.jar' file (#57)

* Updated test runtime configuration (#57)

* Updated task dependencies and fixed jar file name (#57)

* Moved test configurations

* Added RunJPF.jar and RunTest.jar

* Added username to manifest (#57)

* Fixed .class files from jpf-classes.jar and updated Manifest from RunJPF.jar (#57)
@cyrille-artho
Copy link
Member

Looks like it is done, but it's good to have a test that depends on build.properties being in the right place. You can make a new issue for that, in which case I can close this one.

@jeandersonbc
Copy link
Collaborator Author

Sure! I'm opening a new issue for that. Since changes are merged, I think it's ok to close this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants