Narrative die #334
Merged
Narrative die #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentine195
approved these changes
Sep 27, 2024
valentine195
added a commit
that referenced
this pull request
Nov 5, 2024
…le. (#354) * chore(wip): initial impl of narrative dice * Narrative die (#334) * Updated to SWRPG Font for ease of testing * Updated Geometries to Match Roller order (Assuming asc order for labels) * Populated remaining subclasses & adjusted math logic (non-cancelling triumph/despairs). * fix: Adds force dice to the Narrative dice set * fix: Expands possible ways to specify narrative dice, allows spaces, allows number amounts * fix: Adds new RenderableRoller abstract class * fix: Improves behavior when canceling an in-process render * fix: Updates tests to new responses * Added Settings/Functionality for Symbols/Text & Handling Genesys/SWRPG symbol options. (#335) * fix: Fixes imports for file reorg * Narrative die (#344) * Added Settings/Functionality for Symbols/Text & Handling Genesys/SWRPG symbol options. * Updated Lexer to handle full abbreviation lexeme. * Updated Readme for Narrative Dice overview. * Updated Genesys font & ForceRoller logic. (#348) * Added Settings/Functionality for Symbols/Text & Handling Genesys/SWRPG symbol options. * Updated Lexer to handle full abbreviation lexeme. * Updated Readme for Narrative Dice overview. * Updated Genesys font to match EotE mappings. * Updated Force Dice logic as standalone light/dark results. --------- Co-authored-by: Josh <110574859+source-toad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Finished populating Narrative subclasses.
Changes Proposed