Prevent Scripts from running indefinitely

[jerome-baudoux]

The current version of Nashorn Sandbox does not guarantee that scripts will be stopped if they consume too much memory or CPU time.

The problem occurs when the JsEvaluator takes to much time to register its thread to the ThreadMonitor

When this issue happen the following code is executed:

if (threadToMonitor == null) {
  throw new IllegalStateException("Executor thread not set after " + maxCPUTime / MILI_TO_NANO + " ms");
}

The ThreadMonitor will return an error to the user. However this won't prevent the actual script to be executed.
Even worse it will be executed without any kind of monitoring, the script can take as much time and memory it pleases him.

It would be a way better solution to not execute the script if the ThreadMonitor is not actively monitoring the script.

[mxro]

Sorry for the late reply. Looks very good. Merging this in and will prepare a new release with this change included.

Thank you very much for this improvement!!!

[mxro]

0.1.27 including this change has been pushed to Maven Central and should be available there within the next few hours.