Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring, optimalization, new features #23

Merged
merged 8 commits into from
Nov 30, 2017
Merged

Conversation

mgolebsk
Copy link
Contributor

Hi, I've rewrite almost all module. Have a look on it.

@mxro
Copy link
Collaborator

mxro commented Nov 26, 2017

Thank you for the refactoring. I will check it in detail in a few days since I am travelling at the moment!

@mgolebsk
Copy link
Contributor Author

OK, I will wait

@mxro
Copy link
Collaborator

mxro commented Nov 30, 2017

Hi! I had a quick look and it all looks great. Just to confirm, there are only very minor changes to the API is that correct?

Would you be fine with being added to the Contributors section in the readme?

@mgolebsk
Copy link
Contributor Author

Hi! I had a quick look and it all looks great. Just to confirm, there are only very minor changes to the API is that correct?

Yes, it is correct. I have tried not to make unnecessary changes.

Would you be fine with being added to the Contributors section in the readme?

I would appreciate it.

@mxro mxro merged commit 6ecd400 into javadelight:master Nov 30, 2017
@mxro
Copy link
Collaborator

mxro commented Nov 30, 2017

Great, merged the pull request.

Would you like me to use your GitHub handle or your full name. In case of the latter, could you sent to through to me since I couldn't find it on your GitHub profile page.

@mxro
Copy link
Collaborator

mxro commented Nov 30, 2017

Never mind, I found your full name in the comments!

@mgolebsk
Copy link
Contributor Author

My name is: Marcin Gołębski

@mxro
Copy link
Collaborator

mxro commented Nov 30, 2017

All done! I've added you to the Contributors section: commit.

Also, I've released the new version 0.1.0 to Maven Central which includes all the latest changes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants