-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring, optimalization, new features #23
Conversation
Thank you for the refactoring. I will check it in detail in a few days since I am travelling at the moment! |
OK, I will wait |
Hi! I had a quick look and it all looks great. Just to confirm, there are only very minor changes to the API is that correct? Would you be fine with being added to the Contributors section in the readme? |
Yes, it is correct. I have tried not to make unnecessary changes.
I would appreciate it. |
Great, merged the pull request. Would you like me to use your GitHub handle or your full name. In case of the latter, could you sent to through to me since I couldn't find it on your GitHub profile page. |
Never mind, I found your full name in the comments! |
My name is: Marcin Gołębski |
All done! I've added you to the Contributors section: commit. Also, I've released the new version 0.1.0 to Maven Central which includes all the latest changes. Thank you! |
Hi, I've rewrite almost all module. Have a look on it.