Eval with bindings ignoring allowExitFunctions(false) settings

[everestbt]

While trying to wire this up I found an issue with allowExitFunctions(false). When this is set and then eval(String js,Bindings bindings) is called, for example for the script "quit()" it will exit the JVM, counterposed to the intent of the setting.

This appears to be due to the bindings overwriting the original settings. I am not very familiar with Nashorn so my assumptions of the impact of Bindings and the persistence of these methods could be false. For usability I believe it would be helpful that, regardless of Bindings the settings are applied.

[everestbt]

Opened #68.

[everestbt]

This appears to impact all function limitations enforced by bindings, i.e. allowPrintFunctions(false) is not enforced when custom bindings are passed in.

[mxro]

Thanks heaps for the pull request. This is all merged now and published with version 0.1.17! Is the issue resolved now?

[everestbt]

@mxro Thanks for merging it in. I have been working on optimising the fix a little more, I have a bit more testing to do on this but by Tuesday I should have an improved fix on a pull request.

[mxro]

@everestbt That sounds awesome! Looking forward to the fix - will do my best to merge it in faster this time 😃

[everestbt]

@mxro I have introduced a pull request #69 which I think improves things, by removing the extra evaluations by instead caching a set of secured bindings. Take a look and let me know your thoughts, happy to address any comments.

[mxro]

Version 0.1.18 released to Maven Central including this fix. Let me know if there is anything else to be done for this issue, otherwise we can close. Thank you for fixing this 👍

[everestbt]

Great, do you want me to open another issue in relation to ScriptContext having the same issue, there is an ignored test indicating this in the testExit:
@Test @Ignore("This will fail as there is no confirmation on Script Contexts") public void testQuitWithScriptContext() throws ScriptCPUAbuseException, ScriptException { final NashornSandbox sandbox = NashornSandboxes.create(); sandbox.eval("quit();", new SimpleScriptContext()); }

[mxro]

Yes please :)

[everestbt]

I have opened #70. Closing this as resolved.