Use lodash.isnan instead of Number.isNaN

[ohbarye]

Hello, maintainers.

I'm trying to solve #559 with this PR by adding lodash.isnan as a dependency since IE doesn't support Number.isNaN.

ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN

But I'm not sure whether this is the best approach to make polyfill for this project, so if you have a better solution in your mind I'll comply it.

[prichodko]

Libraries shouldn't include any polyfills. However, I wouldn't consider this change as adding polyfill and rather using better module for this operation. I am 👍 .

[jaredpalmer]

This is kinda hard. I’d rather document a polyfill than bloat the lib

[prichodko]

When you inspect the code, it's not really a polyfill, is it? It just uses a different technique to determine NaN. On the other hand, I understand the point.

[vlad-zhukov]

There is no need to bring another dependency because isNaN is a simple value !== value check. See #588 for an alternative to this PR.

[prichodko]

TIL

[ohbarye]

👍