-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nested values proposal prototype (#202) #207
Merged
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2358a91
Added nested values proposal prototype (#202)
klis87 7ce3f6a
Fixed default response in setNestedObjectValues
klis87 a6b53f8
Fixed isObject check in setNestedObjectValues
klis87 491aa43
Refactored to remove lodash set and get dependencies
klis87 fdfe394
Inlined dlv in utils.js
klis87 5e998a1
Fixed mutation bug in setDeep and added setDeep tests
klis87 33539ab
Added array support to setDeep
klis87 d71bda3
Fixed tsconfig.json
klis87 92bb6cb
Merge branch 'master' into nested-values
jaredpalmer 43e8c81
Merge branch 'master' into nested-values
jaredpalmer 2363abc
Fix dlv
jaredpalmer 99cba2a
Fix generic in touchAllFields
jaredpalmer b4b25cb
Fix typo
jaredpalmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,7 @@ | |
"gen-docs": "all-contributors generate && doctoc README.md" | ||
}, | ||
"dependencies": { | ||
"lodash": "4.17.4", | ||
"lodash.isequal": "4.5.0", | ||
"prop-types": "^15.5.10", | ||
"warning": "^3.0.0" | ||
|
@@ -45,6 +46,7 @@ | |
"devDependencies": { | ||
"@types/enzyme": "2.8.4", | ||
"@types/jest": "20.0.6", | ||
"@types/lodash": "4.14.77", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
||
"@types/lodash.isequal": "4.5.2", | ||
"@types/node": "8.0.19", | ||
"@types/prop-types": "15.5.1", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use dlv as described. no need to import all of lodash 😄 !