Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

sensu-go-check: Clean diffs, cleaner args #98

Merged
merged 4 commits into from
May 17, 2019
Merged

sensu-go-check: Clean diffs, cleaner args #98

merged 4 commits into from
May 17, 2019

Conversation

jaredledvina
Copy link
Owner

Alright, next iteration of the module, this PR:

  • Improves the diff setup to be much more accurate
  • Fixes up the arg inputs
  • Adjusts the failure logging during API issues to provide more information
  • Migrates the arguments to use the defaults in the Sensu Go API, this allows us to fully manage the check objects declaratively versus just managing the attributes configured.

I'm getting close to finishing up this module and officially releasing it, only a few more ideas left I think.

Signed-off-by: Jared Ledvina jared@techsmix.net

@jaredledvina
Clean diffs, cleaner args
8a4f2b6 
Signed-off-by: Jared Ledvina <jared@techsmix.net>
@jaredledvina
check mode should set changed
05e9431 
Signed-off-by: Jared Ledvina <jared@techsmix.net>
@jaredledvina
ansible-test sanity -v --docker --python 2.7 sensu_go_check passes
0a4437a 
Signed-off-by: Jared Ledvina <jared@techsmix.net>
@jaredledvina
Fixup some more sanity checks
49f3720 
Signed-off-by: Jared Ledvina <jared@techsmix.net>
@jaredledvina jaredledvina added the enhancement New feature or request label May 17, 2019
@jaredledvina jaredledvina merged commit 0b97e24 into master May 17, 2019
@jaredledvina jaredledvina deleted the feature/more-sensu-go-check-improvements branch May 17, 2019 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaredledvina