Skip to content
This repository has been archived by the owner on Feb 13, 2019. It is now read-only.

refactor gpio to allow configuring individual pins, add missing pins #29

Closed
wants to merge 2 commits into from

Conversation

evq
Copy link
Contributor

@evq evq commented Oct 8, 2017

Hey @japaric :)

I recently have been working on a project using blue-pill that requires more fine-grained control over individual GPIO pins and access to more pins than are currently defined (a keypad for a door entry system). As a result I have taken a swing at changes to allow for this.

I tried to align with your suggested * gpio API for embedded_hal, having separate traits for Input and Output. However, most of the new code handles the various configuration options, so I wasn't sure what you had envisioned.
* rust-embedded/embedded-hal#11

One thing I was wondering about was the selection of the original set of pins. Were they chosen to avoid conflict with pins used by other peripherals? I have only finished enumerating port B pins, but can add pins for the other ports unless there is a reason not to.

If you have some time to review or have any suggestions / input please let me know. Thanks!

@evq
Copy link
Contributor Author

evq commented Nov 26, 2017

I'm going to close this as I'll be adding additional unrelated commits to my master branch - and it looks like there's another take on more fully featured gpio in the works :)

@evq evq closed this Nov 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant