Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved buffer switching (issue #25) #26

Merged
merged 22 commits into from
Jul 17, 2024
Merged

Improved buffer switching (issue #25) #26

merged 22 commits into from
Jul 17, 2024

Conversation

nicholascarroll
Copy link
Contributor

@nicholascarroll nicholascarroll commented Jul 14, 2024

next buffer C-x right
previous buffer C-x left
and C-x b (which used to be next buffer) now lets you cycle through buffer names. The buffer name completion is based on how filename completion works in FInd FIle
changed from [ to * for special buffers eg scratch instead of [scratch]. This is because when people switch buffers they are used to typing C-x b *sc RET to go to scratch

REF: issue #25

@nicholascarroll nicholascarroll marked this pull request as draft July 14, 2024 17:41
@nicholascarroll
Copy link
Contributor Author

I will resolve the conflicts now and resubmit. i put it in draft meanwhile.

@nicholascarroll nicholascarroll marked this pull request as ready for review July 14, 2024 17:44
@nicholascarroll
Copy link
Contributor Author

OK fixed.

Copy link
Owner

@japanoise japanoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to make here but broadly this looks good.

Co-authored-by: japanoise <japanoise@users.noreply.github.com>
@nicholascarroll nicholascarroll marked this pull request as draft July 15, 2024 04:19
Copy link
Contributor Author

@nicholascarroll nicholascarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I implemented Stretchy buffer in tabCompleteFilenames for more efficient handling of lots of buffers. I did notice along the way that editorKillLine which I introduced doesn't put the killed text on the kill ring, however neither does editorKillLineBackwards. I opened issue #27 for that.

@nicholascarroll nicholascarroll marked this pull request as ready for review July 15, 2024 05:50
@nicholascarroll
Copy link
Contributor Author

g2g

@nicholascarroll nicholascarroll changed the title Improved buffer switching Closes #25 Improved buffer switching (issue #25) Jul 15, 2024
@japanoise japanoise merged commit 98d83a3 into japanoise:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants