Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmacs regions #19

Open
japanoise opened this issue Jun 2, 2023 · 5 comments
Open

zmacs regions #19

japanoise opened this issue Jun 2, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@japanoise
Copy link
Owner

i.e. highlight the region and track when it's active, i.e. ready to be highlighted. This would make replace-string and replace-regex more intuitive; when the region is inactive, they should work on the entire file.

@japanoise japanoise added the enhancement New feature or request label Jun 2, 2023
@japanoise
Copy link
Owner Author

  1. C-g marks region inactive
  2. C-spc toggles active if on the mark; sets mark and makes active if not
  3. C-x C-x makes it active

When drawing the screen, eols/newlines should have a reset styles escape code.

@nicholascarroll
Copy link
Contributor

nicholascarroll commented Jul 16, 2024

Is this different to how Emacs works? I am going to make my fork of emsys into a little emacs clone. I will only be adding a couple more commands and then it will be finished. Visible mark using reverse video is one, but I want to try to exactly to match the look and feel of vanilla Emacs.

@nicholascarroll
Copy link
Contributor

So if this issue aims to implement mark functionality different to vanilla Emacs, then I guess my fork is going to diverge. If so then I would like to propose we postpone this issue a few days while I get you some other contributions in via PRs:

  1. POSIX 2001 compliance
  2. Window-based cursors and scrolling so that split view on the one buffer works properly
  3. M-x toggle-truncate-lines and M-x visual-line-mode.
  4. Possibly refactoring editorPrompt so that you can do mark and all the edit commands down there
  5. The other currently open issues
  6. Bugfixing
    Are all those things that you would like to have in emsys?

@japanoise
Copy link
Owner Author

Is this different to how Emacs works? I am going to make my fork of emsys into a little emacs clone. I will only be adding a couple more commands and then it will be finished. Visible mark using reverse video is one, but I want to try to exactly to match the look and feel of vanilla Emacs.

The name "zmacs regions" is a historical artifact. Highlighting the region while active is standard gnu emacs behavior

@nicholascarroll
Copy link
Contributor

nicholascarroll commented Jul 20, 2024

I have implemented visual mark in my branch visual-mark. If you are interested, I would like to resolve a couple doubts before raising a PR:

  • I've done the reverse video in editorDrawRows. Does it make sense to do it there?
  • Some editing functions like editorCopyRegion restore the mark instead of clearing it which confuses me

PR will also wait on my other change issue #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants