This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Make default operator configuration configurable not hardcoded #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .gitignore # controllers/backstage_controller.go # controllers/backstage_controller_test.go # controllers/backstage_deployment.go # controllers/backstage_service.go # controllers/local_db_deployment.go # controllers/local_db_storage.go
rm3l
reviewed
Nov 30, 2023
rm3l
approved these changes
Nov 30, 2023
nickboldt
added a commit
that referenced
this pull request
Dec 5, 2023
Signed-off-by: nickboldt <nickboldt@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Backstage operator to be configured with plain yaml files under config managed by Kustomize, instead of hardcoded yamls.
These yamls eventually become ConfigMap objects and mounted to the Controller's container.
This allow to:
Which issue(s) does this PR fix or relate to
#6
and
#51
How to test changes / Special notes to the reviewer
This PR must not change existing behavior, so make test, make run, make deploy should work as usual