-
Notifications
You must be signed in to change notification settings - Fork 15
Add examples/bs-existing-secret.yaml
to the list of E2E tests
#287
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already addressed in #272
Please target it to 1.1.x
#272 is already big enough ^^, and adding more changes to it makes it even more difficult to review (already 100+ files changed). |
Well, even if we agreed to consider main as development branch, you requested that it must pass all e2e tests from the very initial state, that's what I am doing. |
Yep, for big PRs, tests help reviewers a lot to check the behavior. But alright, since I saw you cherry-picked the changes here in #272, let's close this one then. |
@rm3l: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This includes
examples/bs-existing-secret.yaml
to the list of E2E tests, as I noticed in #272 (comment) that it could be tested as well.Which issue(s) does this PR fix or relate to
—
PR acceptance criteria
rhdh-operator.csv.yaml
file accordinglyHow to test changes / Special notes to the reviewer
make test-e2e
should pass on both OpenShift and Kubernetes. Well, except the one testingexamples/rhdh-cr-with-app-configs.yaml
on OpenShift, which should be fixed by #286.