Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gp3 ebs type #519

Merged
merged 9 commits into from
Apr 20, 2021
Merged

Add gp3 ebs type #519

merged 9 commits into from
Apr 20, 2021

Conversation

spockNinja
Copy link
Contributor

@spockNinja spockNinja commented Jan 25, 2021

Summary

Add gp3 as an EBS volume type.

We are currently receiving an error: ERROR - unknown volume type 'gp3' for volume ...

AWS docs show these as two separate limits. Luckily, the limits appear to behave the same as the gp2 limits.

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Whether or not your PR includes unit tests:
    • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
    • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, that's fine, just mention that in the summary and either
      ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
      include complete test coverage will usually be merged faster.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@spockNinja
Copy link
Contributor Author

@jantman I think I have this one cleaned up and ready for review now. ☺️

@spockNinja
Copy link
Contributor Author

@jantman This is triggering a recurring error in our limit monitoring solution. Does it need anything else before it can be merged?

@sean-zou
Copy link

Getting tons of unknown volume type 'gp3'. Please review and merge this. Thanks!

@jantman jantman merged commit 0dba700 into jantman:develop Apr 20, 2021
@jantman jantman mentioned this pull request Apr 20, 2021
14 tasks
@jantman
Copy link
Owner

jantman commented Apr 21, 2021

This has been released in 11.0.0, which is now live on PyPI. Thank you so much, and apologies for the delay.

@spockNinja
Copy link
Contributor Author

Thank YOU, @jantman, for giving your energy to this project. 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants