Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #418 - Metrics Provider #423

Merged
merged 5 commits into from
Aug 30, 2019
Merged

Fixes #418 - Metrics Provider #423

merged 5 commits into from
Aug 30, 2019

Conversation

jantman
Copy link
Owner

@jantman jantman commented Aug 30, 2019

This PR implements the metrics provider subsystem described in #418, as well as the first two metrics providers: a "Dummy" provider that just outputs metrics to STDOUT for testing, and the Datadog provider.

Both current providers have been tested off of this branch and are functional. The process for adding new providers has been documented.

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #423 into develop will decrease coverage by 1.67%.
The diff coverage is 67.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #423      +/-   ##
===========================================
- Coverage      100%   98.32%   -1.68%     
===========================================
  Files           30       33       +3     
  Lines         2319     2444     +125     
  Branches       345      366      +21     
===========================================
+ Hits          2319     2403      +84     
- Misses           0       41      +41
Impacted Files Coverage Δ
awslimitchecker/metrics/dummy.py 100% <100%> (ø)
awslimitchecker/checker.py 100% <100%> (ø) ⬆️
awslimitchecker/runner.py 100% <100%> (ø) ⬆️
awslimitchecker/metrics/base.py 100% <100%> (ø)
awslimitchecker/metrics/datadog.py 24.07% <24.07%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad5ba6...3e022f9. Read the comment docs.

@jantman jantman merged commit 7f7aade into develop Aug 30, 2019
@jantman jantman deleted the issues/418 branch August 30, 2019 14:01
jantman added a commit that referenced this pull request Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants