Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing instance types #429

Closed
chrislo2004 opened this issue Sep 13, 2019 · 7 comments
Closed

Missing instance types #429

chrislo2004 opened this issue Sep 13, 2019 · 7 comments

Comments

@chrislo2004
Copy link

Hi Jantman,
Before hand, thanks for making a great tool to be used, I really appreciate it!

Ok, so there is an error on unknown instance type 't3a.xlarge'; not counting, hope you can fix this!

version: awslimitchecker 7.1.0

Thanks & Regards

@jantman
Copy link
Owner

jantman commented Sep 17, 2019

@chrislo2004 apologies for the delayed response to this.

awslimitchecker has a hard-coded list of EC2 instance types that it supports. It appears that none of the t3a instances have been added yet. I'll make sure to get this into the next release, though I can't commit to a specific timeline.

@jantman jantman changed the title unknown instance type 't3a.xlarge'; not counting Missing instance types Sep 18, 2019
@jantman
Copy link
Owner

jantman commented Sep 18, 2019

It appears that there are currently 42 instance types missing:

c5.12xlarge
c5.24xlarge
c5.metal
c5n.metal
i3en.12xlarge
i3en.24xlarge
i3en.2xlarge
i3en.3xlarge
i3en.6xlarge
i3en.large
i3en.metal
i3en.xlarge
m5.16xlarge
m5.8xlarge
m5.metal
m5a.16xlarge
m5a.8xlarge
m5ad.12xlarge
m5ad.24xlarge
m5ad.2xlarge
m5ad.4xlarge
m5ad.large
m5ad.xlarge
m5d.16xlarge
m5d.8xlarge
m5d.metal
r5a.16xlarge
r5a.8xlarge
r5ad.12xlarge
r5ad.24xlarge
r5ad.2xlarge
r5ad.4xlarge
r5ad.large
r5ad.xlarge
t3a.2xlarge
t3a.large
t3a.medium
t3a.micro
t3a.nano
t3a.small
t3a.xlarge
z1d.metal

@jantman
Copy link
Owner

jantman commented Oct 28, 2019

Many apologies for the delay in implementing this... it's occasionally difficult to balance life and maintaining an open source project in my spare time. I plan on trying to get a fix for this out in the next week.

@chrislo2004
Copy link
Author

chrislo2004 commented Oct 29, 2019 via email

@jantman
Copy link
Owner

jantman commented Oct 29, 2019

@chrislo2004 I'm working on implementing changes for that right now, see #432. There will be a new release out sometime this week that includes updates for the new vCPU-based limits.

Since AWS can't ever make anything simple, the new vCPU limits aren't being rolled out in the China or US GovCloud regions, so the instance type updates will need to happen as well, in order to support users in those regions.

@jantman
Copy link
Owner

jantman commented Oct 30, 2019

This will be present in the next release, though it will only be helpful for people using the China and GovCloud regions.

@jantman jantman closed this as completed in fde6303 Nov 3, 2019
@jantman
Copy link
Owner

jantman commented Nov 4, 2019

This has been fixed in 8.0.0 which is now live on PyPI and Docker Hub. Apologies for any delays in getting this released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants