-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting / Notifications #419
Labels
Comments
Implementation plan is something similar to Metrics providers...
|
jantman
added a commit
that referenced
this issue
Aug 30, 2019
jantman
added a commit
that referenced
this issue
Sep 3, 2019
Docs updates needed for this:
|
jantman
added a commit
that referenced
this issue
Sep 4, 2019
jantman
added a commit
that referenced
this issue
Sep 5, 2019
jantman
added a commit
that referenced
this issue
Sep 5, 2019
jantman
added a commit
that referenced
this issue
Sep 5, 2019
jantman
added a commit
that referenced
this issue
Sep 6, 2019
jantman
added a commit
that referenced
this issue
Sep 6, 2019
This has been fixed by #425 and will be in the next release. |
This was merged to master in #427 and released as 7.1.0. The release is now live on PyPI and the Docker image should be live on Docker Hub shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My employer would like built-in support in awslimitchecker for notifying/alerting someone when there are warning or critical thresholds crossed (or, in theory, if the run fails). We use PagerDuty but we'd like to make it easy for others to contribute integrations for other notification methods. I'm being allowed to work on this during my work time.
My thought is implementing something similar to the plan in #418 for metrics outputs - we'd have a NotificationProvider base class with a
notify()
method that takes a list of limits with critical thresholds passed and a list of limits with warning thresholds passed, and some configuration information from CLI options. It should also handle sending a notification if the run failed. The first subclass would be PagerDuty, but we'd accept PRs for additional ones.The text was updated successfully, but these errors were encountered: