-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intel Chipset Device Software failing on X1 Yoga gen 7 #83
Comments
It appears that driver might already be installed and is falsely returned by LSUClient as an available update. If you have Lenovo System Update installed too, does it show the same driver as an available update or no? |
When I check Lenovo system update it does not show any available updates. Sorry I didn't include that before |
Thanks, so the cause for the driver showing up again is in here:
The first _Driver test fails because the device Currently I require all hardware IDs listed in a _Driver test to pass which is why this package comes back as not installed yet. I'm going to have to take some time to look into this case and if the behavior can be tweaked to match System Update but without regressing on another end. |
Okay, thanks for looking at it Jantari. |
Up until now I've always required that all matched / found HardwareIDs in a _Driver test pass their tests for the overall _Driver test to pass, but #83 shows this might not be correct. This adds a test variable to easily compare results with the old vs this approach to test regressions
I have run some comparisons of the results when passing _Driver tests if just one found device passes the test vs all like it is currently. Most of the time it does not make a difference but I found a system where it did: Results with current behavior - all matched devices have to pass tests
Results with tested behavior - only one matched device has to pass
This is also an Intel Chipset Driver package but a different one. This was on a Lenovo 20FN (T460). In this example I don't think the IsInstalled test should've passed. The package version is 10.1.5.2 which is clearly an update to the 10.1.1.9 used by the first device, and the Synaptics driver being used for an Intel device feels more like another problem than intentional. But, another idea is that System Update might be failing what it considers inbox drivers. The current driver version in your log is |
This reverts commit fbd2984. I should've created a separate branch for experiments like this, but it was most likely not the right solution anyway. Will try more on other branches.
I'm experiencing a similar issue for Intel Chipset Device Software n3aic05w. Did you find a workaround for this perhaps? Thank your for this great module! |
Hi, please run |
Hi, I've added the output. Thanks for looking into this! |
@hanbongers thank you very much, and since you said you also checked using Lenovo System Update could you upload its logs too? There should be |
@jantari thank you, I've added the .log file of a fresh run of System Update. |
@hanbongers Thanks. This is indeed the exact same issue as @swoonhusker1 has reported. Basically, LSUClient and Lenovo System Update logic seems to differ when evaluating the Lenovo DetectInstall XML for package n3aic05w
LSUClient goes through it here: LSUClient log excerpt
and concludes that the driver is not yet installed (DetectInstall -> 0 (False)) because the device PCI\VEN_8086&DEV_467D, which is listed in Lenovos XML definition, does not have it. System Update on the other hand: System Update log excerpt
doesn't log enough details about its check process to really know what's going on, but we can tell it passes the DetectInstall check, hence concluding that the driver is already installed. We know from LSUClients log that your computer has 5 of the devices (Hardware IDs) that Lenovo wants to check in their XML, we can also see that 4 out of 5 do use a driver that matches their test criteria - but one doesn't. I'm afraid that changing LSUClients logic on when to pass these |
@jantari thanks! Would it help if I provide more cases of differences between LSUClient and LSU? |
If you have more cases, yes that would be very helpful. Please provide the computer model, the difference in results and the |
Version
1.5.3
Computer Model
21CES50100
Problem
Running a get-lsupdate finds the following:
n3aic04w "Intel Chipset Device Software - 10 (20H2 or Later)/11 (21H2 or Later)" 9/19/22 release date
When installing the failure reason is INSTALLER_EXITCODE
I'm attaching logs of the get-lsupdate -verbose -debug and also install-lsupdate.
install-lsupdate debug.log
get-lsupdate debug.log
Additional context
No response
The text was updated successfully, but these errors were encountered: