Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed html syntax highlighting on README.md example #500

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Removed html syntax highlighting on README.md example #500

merged 1 commit into from
Nov 5, 2015

Conversation

imagentleman
Copy link
Contributor

This is just a silly request/nitpick, but with the html syntax highlighting this example looks just like plain text, except for the ampersand, which appears highlighted in red. This could be cause confusion, signaling that there is something "more important" about the ampersand than the rest of keywords (e.g. the delimiters).

@dasilvacontin
Copy link
Collaborator

@imagentleman, I agree with you. It's a shame that GitHub (using Linguist) doesn't recognise Mustache as a language and doesn't support syntax highlighting for it (but it does recognise Handlebars).

@dasilvacontin
Copy link
Collaborator

Could you amend the commit's message to something more descriptive? Like Remove syntax highlighting in README code sample.

@imagentleman
Copy link
Contributor Author

@dasilvacontin, just amended the commit message : )

@bobthecow
Copy link

I've had better luck with html+jinja for mustache snippets. Wanna give that one a shot here?

@imagentleman
Copy link
Contributor Author

@bobthecow Unfortunately, for this snippet in particular html+jinja doesn't highlight anything (does the same as the empty fence block in the pr).

phillipj added a commit that referenced this pull request Nov 5, 2015
Removed html syntax highlighting on README.md example
@phillipj phillipj merged commit 53b1c95 into janl:master Nov 5, 2015
@phillipj
Copy link
Collaborator

phillipj commented Nov 5, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants