Better total (body + attachments) size checking for documents #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the already computed (conservative) body size. Switch multipart length calcuation to accept body and boundary sizes. Issue apache#1200 Issue apache#1253
|
@nickva this is great, thank you! Do you have any ideas about how to handle writes with |
|
Is the length part of the stub too? I forgot... |
|
The question is then do we validate the lengths? I don't think we do... That the stub might have length: 0 but the attachment on disk could be 1GB. Maybe when merging stubs we also validate that provided lengths match too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the already computed (conservative) body size.
Switch multipart length calcuation to accept body and boundary sizes.
Issue apache#1200
Issue apache#1253