-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling constructor may break stack map when "assert" option is disabled #119
Comments
HeartSaVioR
added a commit
to HeartSaVioR/janino
that referenced
this issue
Mar 14, 2020
…nitializedVariableOperand() via moving popOperand() out of "assert"
This was referenced Mar 14, 2020
aunkrig
added a commit
that referenced
this issue
Mar 16, 2020
Merged PR #120 which fixes this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is another one of test failures I've seen in Spark with Janino 3.1.1.
Please add below tests into ExpressionEvaluatorTest and run to see the failures:
The culprit looks to be here:
janino/janino/src/main/java/org/codehaus/janino/CodeContext.java
Lines 1439 to 1445 in 8dc7efc
Here assertion calls "stateful" method which affects result if assertion is disabled.
The text was updated successfully, but these errors were encountered: