Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: google tag manager #562

Merged
merged 4 commits into from
Nov 13, 2023
Merged

web: google tag manager #562

merged 4 commits into from
Nov 13, 2023

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Nov 7, 2023 •
edited
Loading

Problem:

  • Marketing or Designer will be block by developer bc they need inject script inside the element

Solution:

  • Install GTM id as wrapper, so when Marketing and Designer need some tools eg: hotjar, posthug etc, they can install via manually and will automatically reflect to production site

Docs: Docusaurus

@urmauur urmauur marked this pull request as ready for review November 7, 2023 16:09
@urmauur urmauur requested a review from louis-menlo November 8, 2023 01:43
@hiento09 hiento09 force-pushed the google-tag-manager branch 5 times, most recently from 5105a87 to 122c52b Compare November 13, 2023 08:36
louis-menlo
louis-menlo reviewed Nov 13, 2023
View reviewed changes
.github/workflows/jan-docs.yml
done < "$env_example_file"
working-directory: docs
env:
SECRETS: '${{ toJson(secrets) }}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks @hiento09

louis-menlo
louis-menlo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit bff2588 into main Nov 13, 2023
1 check passed
@urmauur urmauur deleted the google-tag-manager branch November 13, 2023 08:44
@louis-menlo louis-menlo added the type: chore Maintenance, operational label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-menlo louis-menlo louis-menlo approved these changes

Assignees
No one assigned
Labels
type: chore Maintenance, operational
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urmauur @louis-menlo @jan-service-account