Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable app update on test #521

Merged
merged 10 commits into from
Nov 1, 2023
Merged

chore: disable app update on test #521

merged 10 commits into from
Nov 1, 2023

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Nov 1, 2023 •
edited
Loading

Problem

  • Build for distribution will take a very long time to finish test
  • Build for dir will break app autoUpdate feature

Changes

  • Disable app autoUpdate on test
  • Build for dir only on test

@louis-jan louis-jan requested a review from hiento09 November 1, 2023 06:33
@hiento09 hiento09 merged commit f02f769 into main Nov 1, 2023
3 checks passed
@hiento09 hiento09 deleted the chore/disable-update-on-test branch November 1, 2023 10:29
@hiento09 hiento09 mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @hiento09