Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add New Conversation button on the conversation sidebar #499

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat: add New Conversation button on the conversation sidebar #499

merged 2 commits into from
Oct 30, 2023

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Oct 30, 2023 •
edited
Loading

Fixing #485

Case scenario

  • When user have history list and want to create new conversation, will create new conversation with current active model
Screenshot 2023-10-30 at 22 40 11
  • When user create new conversation but model not active, will showing popup and let user go to my model page to active the model
Screenshot 2023-10-30 at 22 40 43

NB: @0xSage we move button new conv to top to avoid case when user have a lot of list, and the button will be sticky when user scroll the list

Screenshot 2023-10-30 at 22 43 45

louis-menlo
louis-menlo approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 3f12b7d into main Oct 30, 2023
@urmauur urmauur deleted the feat/new-conversation branch October 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-menlo louis-menlo louis-menlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-menlo