Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max_tokens revert back to 8192 automatically when creating a new thread #4397

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jan 3, 2025

Describe Your Changes

This PR addresses an issue where the app resets the max_tokens to 8192 whenever users create a new thread. This occurs because the parameter retrieve when creating a new thread is incorrect. It should instead use the max_tokens from the model settings instead of token_limit.

CleanShot 2025-01-03 at 12 57 28

Fixes Issues

Changes made

This pull request includes a small but important change to the useCreateNewThread function in web/hooks/useCreateNewThread.ts. The change corrects the parameter name from token_limit to max_tokens to ensure the correct value is used.

  • Corrected the parameter name from token_limit to max_tokens in useCreateNewThread function to ensure the correct value is used.

@louis-jan louis-jan added this to the v0.5.13 milestone Jan 3, 2025
@github-actions github-actions bot added the type: bug Something isn't working label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Barecheck - Code coverage report

Total: 68.71%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/hooks/useCreateNewThread.ts139-140, 142-143, 150-151, 162, 171, 208, 212, 214

@louis-jan louis-jan merged commit f69c31b into main Jan 3, 2025
15 of 16 checks passed
@louis-jan louis-jan deleted the fix/max_tokens-automatically-revert-when-users-create-new-thread branch January 3, 2025 06:12
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants