Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Jan Docs (1) #4362

Merged
merged 29 commits into from
Jan 7, 2025
Merged

chore: Update Jan Docs (1) #4362

merged 29 commits into from
Jan 7, 2025

Conversation

imtuyethan
Copy link
Contributor

@imtuyethan imtuyethan commented Dec 30, 2024 •
edited
Loading

Describe Your Changes

Update:

  • Hide Error Codes page (we didn't implement it)
  • Overview page
  • Quickstart page
  • Desktop pages -> Installation pages

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@imtuyethan imtuyethan changed the title Chore/update jan docs chore: Update Jan Docs (Overview, Quickstart & Installation pages) Dec 30, 2024
@github-actions github-actions bot requested a deployment to docs (Preview) December 30, 2024 14:13 Abandoned
@github-actions GitHub Actions
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@imtuyethan imtuyethan changed the title chore: Update Jan Docs (Overview, Quickstart & Installation pages) chore: Update Jan Docs Dec 31, 2024
@github-actions github-actions bot requested a deployment to docs (Preview) December 31, 2024 02:26 Abandoned
@github-actions github-actions bot requested a deployment to docs (Preview) January 1, 2025 16:30 Abandoned
@github-actions github-actions bot requested a deployment to docs (Preview) January 1, 2025 16:41 Abandoned
@louis-jan
Copy link
Contributor

@imtuyethan, same #4380 (comment)

@github-actions github-actions bot requested a deployment to docs (Preview) January 2, 2025 16:50 Abandoned
@louis-jan
Copy link
Contributor

Looks way so good now. @imtuyethan

@urmauur
Copy link
Member

urmauur commented Jan 6, 2025

@imtuyethan deploy preview was failed, a couple assets missing
https://github.com/janhq/jan/actions/runs/12622247906/job/35169952766?pr=4362

Screenshot 2025-01-06 at 10 57 26

@imtuyethan imtuyethan requested review from urmauur and removed request for eckartal and dan-menlo January 7, 2025 02:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

Preview URL: https://3b22baf3.docs-9ba.pages.dev

@imtuyethan imtuyethan merged commit 2c4acb3 into dev Jan 7, 2025
1 check passed
@imtuyethan imtuyethan deleted the chore/update-jan-docs branch January 7, 2025 07:42
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 7, 2025
@imtuyethan imtuyethan restored the chore/update-jan-docs branch January 7, 2025 07:46
@imtuyethan imtuyethan deleted the chore/update-jan-docs branch January 7, 2025 07:46
@imtuyethan imtuyethan restored the chore/update-jan-docs branch January 7, 2025 07:46
@imtuyethan imtuyethan deleted the chore/update-jan-docs branch January 7, 2025 07:49
@imtuyethan imtuyethan changed the title chore: Update Jan Docs chore: Update Jan Docs (2) Jan 7, 2025
@imtuyethan imtuyethan changed the title chore: Update Jan Docs (2) chore: Update Jan Docs (1) Jan 7, 2025
@imtuyethan imtuyethan restored the chore/update-jan-docs branch January 7, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@urmauur urmauur Awaiting requested review from urmauur

Assignees

@imtuyethan imtuyethan

Labels
None yet
Projects
None yet
Milestone
v0.5.14
Development

Successfully merging this pull request may close these issues.
3 participants
@imtuyethan @louis-jan @urmauur