Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core services and module export #376

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

louis-jan
Copy link
Contributor

Problem

Since we renamed @janhq/plugin-core to @janhq/core, its not so reasonable to

import { core } from "@janhq/core" ;
core.downloadFile("");

// OR

import * as core from "@janhq/core"
core.core.downloadFile("")

Solution

Core module should export all functions so:

import { downloadFile } from "@janhq/core" ;
downloadFile("");

// OR

import * as core from "@janhq/core"
core.downloadFile("")

@louis-jan louis-jan marked this pull request as ready for review October 17, 2023 10:27
@louis-jan louis-jan requested a review from hiento09 October 17, 2023 10:28
@louis-jan louis-jan merged commit b460426 into main Oct 17, 2023
@louis-jan louis-jan deleted the chore/update-core-services branch October 17, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants