Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature windows nsis #2705

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Feature windows nsis #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
06d111a
Add nsis for windows
hiento09 Apr 12, 2024
578dc2d
Revert to one click true
hiento09 Apr 15, 2024
ac9228b
Add nsis for windows
hiento09 Apr 12, 2024
21fdac0
Revert to one click true
hiento09 Apr 15, 2024
36733f0
Merge branch 'feature/windows-nsis' of github.com:janhq/jan into feat…
hiento09 Apr 17, 2024
1fdd3ab
Add nsis for windows
hiento09 Apr 12, 2024
0f97850
Revert to one click true
hiento09 Apr 15, 2024
a87a0ea
Merge branch 'feature/windows-nsis' of github.com:janhq/jan into feat…
hiento09 Apr 17, 2024
2d84a9c
Update message for uninstallation messageBox
hiento09 Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added electron/icons/icon.ico
View file
Open in desktop
Binary file not shown.
7 changes: 7 additions & 0 deletions electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@
"nsis"
]
},
"nsis": {
"oneClick": true,
"installerIcon": "icons/icon.ico",
"uninstallerIcon": "icons/icon.ico",
"include": "scripts/uninstaller.nsh",
"deleteAppDataOnUninstall": true
},
"artifactName": "jan-${os}-${arch}-${version}.${ext}"
},
"scripts": {
Expand Down
18 changes: 18 additions & 0 deletions electron/scripts/uninstaller.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
!include nsDialogs.nsh

XPStyle on

!macro customUnInstall
; Uninstall process execution
${ifNot} ${isUpdated}
# If you tick Delete fixed folder
MessageBox MB_OKCANCEL "Do you also want to delete the DEFAULT Jan data folder at $PROFILE\jan?" IDOK label_ok IDCANCEL label_cancel
label_ok:
# Delete user data folder
RMDir /r $PROFILE\jan
Goto end
label_cancel:
Goto end
end:
${endIf}
!macroend
Loading