Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Default instruction from ~/jan/assistants/jan/assistant.json no longer work on linux #3515

Closed
2 of 4 tasks
eregnier opened this issue Sep 2, 2024 · 4 comments · Fixed by #3721
Closed
2 of 4 tasks
Assignees
Labels
category: threads & chat Threads & chat UI UX issues os: linux Linux issues P0: critical Mission critical type: bug Something isn't working

Comments

@eregnier
Copy link

eregnier commented Sep 2, 2024

  • I have searched the existing issues

Current behavior

default instructions are no longer read from the configuration file when launching a new thread on linux.
I tried to remove the ~/jan file, remove my .AppImage file and install it from deb source (with today latest version) then fill again the "instructions" field in ~/jan/assistant/jan/assistant.json . Nothing work. I have to copy / paste my instructions from one thread to another instead of just spawning a new thread and go with my "all purpose for my needs" dev instructions.

Thank you for this tool, it is awesome.

By the way, this default assistant behavior is poorly documented (or I my searched does not match this feature documentation easily) , I had to search in github issues to find a way to do this basic (at least for me) thing.

Minimum reproduction step

do a fresh install under ubuntu by removing the ~/jan folder
fill "instructions" field in the assistant.json file
run jan
-> no default instructions are displayed anymore

image

Expected behavior

instruction field is filled with the value I wrote in assistant.json file

Screenshots / Logs

image
image

Jan version

0.5.3

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Environment details

Ubuntu 24.04.1 LTS
Intel I7 CPU gen 13
32Go Memory

@eregnier eregnier added the type: bug Something isn't working label Sep 2, 2024
@imtuyethan imtuyethan changed the title bug: [DESCRIPTION] default instruction from ~/jan/assistants/jan/assistant.json no longer work on linux bug: Default instruction from ~/jan/assistants/jan/assistant.json no longer work on linux Sep 2, 2024
@imtuyethan imtuyethan moved this to Need Investigation in Menlo Sep 2, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Sep 4, 2024

The issue is reproducible, modifying Jan's Instructions does not save to the assistant.json, and vice vesa, value from assistant.json does not display to instruction.
Need to confirm whether this is the expected behavior. ⚠️
Current behaviors: the instructions only saved into threads.json
image

@freelerobot freelerobot added os: linux Linux issues P0: critical Mission critical labels Sep 5, 2024
@imtuyethan imtuyethan added this to the v0.5.5 milestone Sep 18, 2024
@imtuyethan imtuyethan moved this from Need Investigation to Scheduled in Menlo Sep 18, 2024
@imtuyethan imtuyethan added the category: threads & chat Threads & chat UI UX issues label Sep 18, 2024
@github-project-automation github-project-automation bot moved this from In Review to Completed in Menlo Sep 24, 2024
@github-project-automation github-project-automation bot moved this from In Review to Completed in Menlo Sep 24, 2024
@imtuyethan
Copy link
Contributor

Tested on

VM 117 Ubuntu

Result

I changed the instructions in the assistant.json file and saved it. Then I quit Jan & opened Jan again to see the instruction was not saved to the threads level. I opened the assistant.json file again & saw that the new instruction was still saved.

Screenshot 2024-10-01 at 10 06 23 PM

@imtuyethan imtuyethan reopened this Oct 1, 2024
@github-project-automation github-project-automation bot moved this from Review + QA to In Progress in Menlo Oct 1, 2024
@imtuyethan imtuyethan modified the milestones: v0.5.5, v0.5.6 Oct 1, 2024
@louis-menlo
Copy link
Contributor

Hi @imtuyethan, you need to create a new thread to see the new changes applied, as the old thread already contains persisted assistant metadata.

@imtuyethan imtuyethan modified the milestones: v0.5.6, v0.5.5 Oct 2, 2024
@imtuyethan imtuyethan moved this from In Progress to Completed in Menlo Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Completed to Review + QA in Menlo Oct 2, 2024
@imtuyethan
Copy link
Contributor

Tested again, it worked, thank you

@imtuyethan imtuyethan moved this from Review + QA to Completed in Menlo Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: threads & chat Threads & chat UI UX issues os: linux Linux issues P0: critical Mission critical type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants