-
Notifications
You must be signed in to change notification settings - Fork 135
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Cortex.cpp Data Structures #1040
Comments
I think we can separate application binary and data:
We have different folders to store different application data builds:
We also have an application config file which allow user to change the data path and other parameters with the default values mentioned above. |
I put my comment here https://github.com/janhq/cortex/issues/1039#issuecomment-2327901258 cc @dan-homebrew @namchuai @vansangpfiev . (Ex for windows:
|
@vansangpfiev - this is well thought through. Questions:
~/.cortex-platform
~/.jan cc @louis-jan @marknguyen1302 for context when thinking through Cortex Platform data folders So for a user who uses Jan, the most top level application, altogether do they have: ~/.jan
~/.cortex-platform
~/.cortex
|
@0xSage Let's scope this discussion to
A few points:
Additionally, should this folder be hidden? (e.g. |
I agree, we can use |
Should we put configuration file It's weird if cortex config is in ~, but engine configs are in .cortex.cpp |
I think it matches how .vimrc, etc work - all in root
…On Wed, 4 Sep 2024 at 2:00 PM, Nicole Zhu ***@***.***> wrote:
Should we put configuration file .cortexrc inside the data folder
.cortex.cpp, i.e related data together, making it easier for users to
find and manage their configuration files.
It's weird if cortex config is in ~, but engine configs are in .cortex.cpp
—
Reply to this email directly, view it on GitHub
<#1040 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYDVXFTRXAMA3ZILZJBLI2DZU2OXVAVCNFSM6AAAAABNHSW42WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXHE4DKNRTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The purpose of the |
Nit: naming a data folder: And should we be consistent across package names & folder names, e.g. Option 1 Option 2 Sorry to nitpick, but this is one of those things where changing in the future is a pain. |
Yep, I completely agree that the app/package name and the app data folder should be consistent with each other to avoid confusing the user. Now we just need to finalize the name. |
@dan-homebrew , the naming of the folder and the binary file is up to us. However, I searched and found that no one uses a dot in their package name or app name. You can refer to it here: https://github.com/Homebrew/homebrew-core/tree/master/Formula/c. I think we should consider @0xSage 's options 1 and 2 above. Including a character that violates naming rules for package names or app names on other platforms (brew, npm) could cause us significant difficulties later on. |
Cool, I suggest just cortexcpp then? From a product perspective:
|
If I have one vote then I will vote for option 1 |
@namchuai @vansangpfiev @nguyenhoangthuan99 @hiento09 Did we make a decision on whether it should be a hidden folder, or a visible folder? Referring to my post in #1092: Folder name should be Cortex Model Folder VisibilityShould it be a visible folder instead? i.e. Application data:
We will have different folders for nightly, i.e:
Config File
Execution file (Cortex Binary)
|
I've also updated the naming structure of Cortex files that the Installer + Uninstaller will track: Installer:
|
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Overview
An unopinionated (hopefully) to store cortex's files and folders.
Couple of requirements:
Discussion
/cortex
folder (will there be namespace collisions?).cortex
Related
The text was updated successfully, but these errors were encountered: