Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pub(crate) instead of pub #256

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

TimJentzsch
Copy link
Collaborator

@TimJentzsch TimJentzsch commented Apr 9, 2023

Closes #253.

This PR find-and-replaces pub with pub(crate) (it's a lot).

It also fixes the dead code warnings that emerged from this change.

I recommend to review this by commit to make it a bit easier :)

@janhohenheim
Copy link
Owner

janhohenheim commented Apr 10, 2023

Thanks!
Congrats for all the LOC attributed to you now 😜

@janhohenheim janhohenheim merged commit d1d4769 into janhohenheim:main Apr 10, 2023
janhohenheim added a commit that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pub(crate) in place of pub
2 participants