Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch the v0.14.1 opam release with a byte code fix. #9

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

andrewray
Copy link

The masking function called for bytecode in bits_stubs.c calls the wrong
value conversion function, and basically breaks the bits api.

This patches it to call the correct function.

The native code was correct.

The masking function called for bytecode in bits_stubs.c calls the wrong
value conversion function, and basically breaks the bits api.

This patches it to call the correct function.

The native code was correct.

Signed-off-by: andrewray <evilkidder@gmail.com>
@andrewray andrewray force-pushed the v0.14.2-fix-bytecode-bits-stubs branch from eb23638 to 4164966 Compare March 24, 2021 15:11
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Mar 25, 2021
@cwong-ocaml cwong-ocaml merged commit 02c41d4 into v0.14 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants