Resolve Infinite Retry Loop on Database Outage and Enhance Buffer Shutdown Behavior #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #224, where the
TimedOverflowBuffer
would enter an infinite retry loop during database outages, blocking system shutdown and restart workflows. Key changes include:Retry Backoff on Flush:
retry_backoff
andshutdown_backoff
mechanisms to manage retries during normal operations and shutdown.Graceful Shutdown Enhancements:
Test Coverage:
test_job_buffer_callback_exception_during_teardown
to validate handling of exceptions during buffer shutdown.Documentation and Cleanup:
Thanks to @AntonKarabaza for assisting with testing.