New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate and enforce last_status_number column of backend #758

Merged

paulgb merged 6 commits into main from paul/dis-2212-populate-last_status_number-when-writing-a-backend-status

Jun 25, 2024

Member

paulgb commented Jun 25, 2024

This bails from updating the backend status if the existing status is greater or equal to the new status.

If the existing last_status_number is NULL, this will always succeed.

paulgb added 2 commits

June 25, 2024 13:41


          populate last_status_number column of backend

58df126


          log new_status

2267d67

paulgb requested review from rolyatmax and michaelsilver

June 25, 2024 17:45

vercel bot commented Jun 25, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plane	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2024 6:47pm


          populate backend_status_number on initial row creation

b75423b

vercel bot deployed to Preview

June 25, 2024 17:51

View deployment

rolyatmax reviewed

View reviewed changes

plane/src/database/backend.rs Outdated Show resolved Hide resolved

rolyatmax reviewed

View reviewed changes

plane/src/database/backend.rs Outdated Show resolved Hide resolved

rolyatmax reviewed

View reviewed changes

plane/src/database/backend.rs Outdated Show resolved Hide resolved

rolyatmax approved these changes

View reviewed changes

Member

rolyatmax left a comment

Code looks good - sorry for the nits, but it looks like the terms last_status, current_status, and new_status are being used in slightly confusing ways. Mind if we stick to the two terms last_status and new_status (or next_status) while in that function?


          Fix test

ae31bab

vercel bot deployed to Preview

June 25, 2024 18:09

View deployment

rolyatmax reviewed

View reviewed changes

plane/src/database/backend.rs Outdated Show resolved Hide resolved


          nits from PR

060d15b

vercel bot deployed to Preview

June 25, 2024 18:17

View deployment

rolyatmax reviewed

View reviewed changes

plane/src/database/backend.rs Outdated Show resolved Hide resolved

rolyatmax reviewed

View reviewed changes

plane/src/database/connect.rs Show resolved Hide resolved


          Add backend to log

2cf6d13

vercel bot deployed to Preview

June 25, 2024 18:47

View deployment

rolyatmax approved these changes

View reviewed changes

paulgb merged commit 0d87b75 into main

6 checks passed

paulgb deleted the paul/dis-2212-populate-last_status_number-when-writing-a-backend-status branch

June 25, 2024 19:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet