Create a BackendStatus -> numeric mapping #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend status lifecycle has a strict ordering. Backends can move forward in the lifecycle, but not backwards.
On the Rust side,
BackendStatusisPartialOrd, so we can do natural comparisons between backend statuses as they relate to this order. However, on the database side, they are just strings.We would like to add constraints at the database level, such as "a backend status can never go backwards". In the database, statuses are represented as strings. We could re-implement the comparison logic in the database as a function over strings, but I don't love having the logic live in both Rust and the database.
The alternative implemented here is to create a function from
BackendStatus->i32which produces a number that reflects the natural order of statuses.No Plane behavior is changed in this PR. The next step is to do a migration that stores these numbers alongside the status.