dont write to routes cache if None #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paulgb
approved these changes
May 30, 2024
|
Built the quickstart image and pulled into the Jamsocket dev CLI to test locally. Can confirm this fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the Proxy cached
Noneroute_info values. This meant that hitting the proxy before a backend reached the Ready state would cause the Proxy to cacheNonefor the backend's route info and make it impossible to reach the backend on subsequent requests - even after the backend has reached a Ready state.Wanted to get this out quickly, so I'm not doing it as part of this PR - but we should differentiate between backends that are
410 Gone, backends that are404 Not Found, and backends that are still starting up (possibly a425 Too Earlyor a503 Service Unavailable?)