Initial structured logging support #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rolyatmax
reviewed
Jan 22, 2024
plane/src/database/backend.rs
Outdated
| pub struct TerminationCandidate { | ||
| pub backend_id: BackendName, | ||
|
|
There was a problem hiding this comment.
Nit: is this newline intentional?
rolyatmax
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for structured logging to Plane.
PLANE_LOG_JSONis set to a value other thanfalse(or empty). If so, we output logs in JSON instead of colored log lines.valuable, which allows us to define types that serialize into JSON when JSON output is used.chronofor better formatting in logs and more configurable serialization.valuable::Valuableon existing types (LoggableTimeforDateTime<Utc>;BackendAddrforSocketAddr)As a follow-up, we should add some spans to capture contextual data, and tweak log levels for dependencies, but this is a big improvement on what we have now.