Add information to terminated backends #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rolyatmax
reviewed
Jan 22, 2024
…ated-backends-in-plane2
…ated-backends-in-plane2
…ated-backends-in-plane2
rolyatmax
reviewed
Jan 26, 2024
| ) | ||
| values ($1, $2, $3, now(), $4, now() + $5, $6, now()) | ||
| values ($1, $2, $3, now(), $4, now() + $5, $6, now(), $11) |
There was a problem hiding this comment.
Is this supposed to be $7 instead of $11?
There was a problem hiding this comment.
no, this is the value for state, which is the 11th argument in the list below. $7 is key.name.
rolyatmax
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc on old <> new state mapping: https://docs.google.com/document/d/11bSSsr4uoA8fFmNyub0FqYiE-mqBZ6hTHxmoEInMTyc/edit
This adds information to the backend state:
reasonis an optional reason that a backend was terminated, which can beSwept,External(i.e. API or CLI), orKeyExpired.reasonisNoneif the backend is still running or exited on its own.last_statusrecords the last status before a backend entered theTerminatingorTerminatedstate.