Improve cluster ergonomics #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e4cb98d to
93bbfa8
Compare
paulgb
commented
Jan 19, 2024
| @@ -285,6 +285,9 @@ impl ExecutorConfig { | |||
|
|
|||
| #[derive(Clone, Serialize, Deserialize, Debug)] | |||
| pub struct SpawnConfig { | |||
| /// Cluster to spawn to. Uses the controller default if not provided. | |||
| pub cluster: Option<ClusterName>, | |||
There was a problem hiding this comment.
Spawn config now takes an optional cluster name. If it is not provided, we fall back on the default cluster name set on the controller.
rolyatmax
reviewed
Jan 19, 2024
| Ok(Json(status)) | ||
| } | ||
|
|
||
| pub async fn handle_backend_status_stream( | ||
| Path((_cluster, backend_id)): Path<(ClusterName, BackendName)>, // TODO: check cluster id | ||
| Path(backend_id): Path<BackendName>, // TODO: check cluster id |
There was a problem hiding this comment.
Is this comment out of date now?
rolyatmax
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few things I don't like about clusters right now:
Since keys are (by default) shared across all clusters managed by a container, there is a weird thing where you can request a connection to a certain cluster's endpoint and get back a result from another cluster. Logically, it makes sense to consider the cluster as part of the (optional) spawn configuration. In fact, a connect request that only wants to connect to an existing backend should not need to specify a cluster at all.
I expect the majority of self-hosting users will want only a single cluster, but they are forced to specify a cluster in every CLI command and connect request. This PR allows a
default_clusterto be set in the controller, which is then applied if no cluster is provided in a connect request.Internally, even though the
backend_idis unique across all clusters managed by the same controller, we effectively use the entire (cluster, backend) pair as a key for backends. This creates some unnecessary complexity that we can eliminate by using backend alone as the ID.This also bumps the version to 0.4.1.