Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds tracing spans to tracing_subscriber capture #540

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

pretentious7
Copy link
Contributor

@pretentious7 pretentious7 commented Jan 9, 2024

This is useful because it means the #[tracing::instrument] decoration on some thing immediately shows up in logs.

Otherwise it only shows up alongside a tracing event (info!, debug! etc)

This is useful because it means the #[tracing::instrument]
decoration on some thing immediately shows up in logs.
@pretentious7 pretentious7 requested a review from paulgb January 9, 2024 20:37
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 8:38pm

Copy link
Member

@paulgb paulgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, sgtm

@pretentious7 pretentious7 merged commit 1c576ac into main Jan 9, 2024
6 checks passed
@pretentious7 pretentious7 deleted the abhi/tracing-span branch January 9, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants