Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use git root as scratch dir base for tests #536

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

pretentious7
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 3:48pm

Copy link
Member

@paulgb paulgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Just to confirm, this is just an ergonomics thing, it's not to fix anything, right?

We should also move test-scratch into the .gitignore in root (I think it is already in the .gitignore in plane/)

@pretentious7
Copy link
Contributor Author

I like this! Just to confirm, this is just an ergonomics thing, it's not to fix anything, right?

We should also move test-scratch into the .gitignore in root (I think it is already in the .gitignore in plane/)

It is in the root, so since I move the plane-tests in one more level, the artifact uploader has been broken, this fixes that.

@pretentious7 pretentious7 merged commit 1ab6580 into main Jan 5, 2024
5 checks passed
@pretentious7 pretentious7 deleted the abhi/fix-test-scratch-dir branch January 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants