Final 'initial migration' changes #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rolyatmax
reviewed
Jan 4, 2024
| comment on column controller.first_seen is 'The first time the controller came online.'; | ||
| comment on column controller.last_heartbeat is 'The last time the controller sent a heartbeat.'; | ||
| comment on column controller.is_online is 'Whether the controller is online (self-reported; if a controller dies suddenly this will not be updated).'; | ||
| comment on column controller.plane_version is 'The version of the plane running on the controller.'; |
There was a problem hiding this comment.
nit: "the version of plane..."
rolyatmax
approved these changes
Jan 4, 2024
d881460 to
9fe6b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we deploy this in staging, we will only be able to do DB changes by creating new migrations, so I wanted to take this last chance to clean up the migrations.
This PR:
clusterfrombackend_key. I couldn't decide what the "right" behavior is for Plane, but every behavior I could think of is accomplishable through some combination of namespace/tag.