fix dev/psql.sh script when running docker compose #1
Annotations
12 warnings
|
check-rust-format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
check-rust-format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check-rust-format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check-rust-format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check-rust-format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
you should consider adding a `Default` implementation for `RouteMap`:
plane2/src/proxy/route_map.rs#L24
warning: you should consider adding a `Default` implementation for `RouteMap`
--> plane2/src/proxy/route_map.rs:24:5
|
24 | / pub fn new() -> Self {
25 | | Self {
26 | | routes: Mutex::new(LruCache::new(
27 | | NonZeroUsize::new(CACHE_SIZE).expect("Always valid conversion from constant."),
... |
31 | | }
32 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try adding this
|
23 + impl Default for RouteMap {
24 + fn default() -> Self {
25 + Self::new()
26 + }
27 + }
|
|
|
you should consider adding a `Default` implementation for `ProxyState`:
plane2/src/proxy/proxy_service.rs#L36
warning: you should consider adding a `Default` implementation for `ProxyState`
--> plane2/src/proxy/proxy_service.rs:36:5
|
36 | / pub fn new() -> Self {
37 | | Self {
38 | | route_map: RouteMap::new(),
39 | | http_client: hyper::Client::builder().build_http::<hyper::Body>(),
... |
42 | | }
43 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try adding this
|
35 + impl Default for ProxyState {
36 + fn default() -> Self {
37 + Self::new()
38 + }
39 + }
|
|
|
you should consider adding a `Default` implementation for `ConnectionMonitorHandle`:
plane2/src/proxy/connection_monitor.rs#L89
warning: you should consider adding a `Default` implementation for `ConnectionMonitorHandle`
--> plane2/src/proxy/connection_monitor.rs:89:5
|
89 | / pub fn new() -> Self {
90 | | let monitor: Arc<Mutex<ConnectionMonitor>> = Arc::default();
91 | |
92 | | let handle = {
... |
147 | | Self { monitor, handle }
148 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
help: try adding this
|
88 + impl Default for ConnectionMonitorHandle {
89 + fn default() -> Self {
90 + Self::new()
91 + }
92 + }
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
plane2/src/proxy/cert_manager.rs#L215
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> plane2/src/proxy/cert_manager.rs:215:44
|
215 | let result = get_certificate(&cluster, &acme_config, request_sender, response_receiver).await;
| ^^^^^^^^^^^^ help: change this to: `acme_config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
plane2/src/proxy/cert_manager.rs#L215
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> plane2/src/proxy/cert_manager.rs:215:34
|
215 | let result = get_certificate(&cluster, &acme_config, request_sender, response_receiver).await;
| ^^^^^^^^ help: change this to: `cluster`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
you should consider adding a `Default` implementation for `NameParser<T>`:
plane2/src/names.rs#L98
warning: you should consider adding a `Default` implementation for `NameParser<T>`
--> plane2/src/names.rs:98:5
|
98 | / pub fn new() -> Self {
99 | | Self {
100 | | _marker: std::marker::PhantomData,
101 | | }
102 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
97 + impl<T: Name> Default for NameParser<T> {
98 + fn default() -> Self {
99 + Self::new()
100 + }
101 + }
|
|
|
called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`:
plane2/src/dns/mod.rs#L160
warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
--> plane2/src/dns/mod.rs:160:9
|
160 | self.loop_handle.take().map(|handle| handle.abort());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
| |
| help: try: `if let Some(handle) = self.loop_handle.take() { handle.abort() }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
= note: `#[warn(clippy::option_map_unit_fn)]` on by default
|