Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File system without file channel support #682

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tbrunsch
Copy link

@tbrunsch tbrunsch commented Feb 8, 2025

Added support for FileSystemProviders without FileChannel implementations

@jamesmudd jamesmudd self-requested a review February 13, 2025 19:27
@jamesmudd
Copy link
Owner

This looks great, thanks so much for this work! Only thing I would like to ask. The new FileChannelFromSeekableByteChannel only has about 15% coverage. This is reasonable as its only used for reading ATM, could you add some tests for the other methods. Or even look at adding writing support using this which would also be great.

But will be great to merge this and have a release improving file system support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants